Skip to content

feat: replace encryption with b64 encoding#289

Merged
arturshadnik merged 9 commits intomainfrom
enh/encoding
Jun 16, 2025
Merged

feat: replace encryption with b64 encoding#289
arturshadnik merged 9 commits intomainfrom
enh/encoding

Conversation

@arturshadnik
Copy link
Copy Markdown
Member

Issue

#281

Description

Since the purpose of encrypting secret values was simply to obfuscate, rather than truly encrypt, we can simplify the process by base64 encoding them instead.

This PR:

  • switches all secret encryption to base64 encoding
  • removes the now unused crypto pkg
  • updates integration tests to replace the encrypted values with encoded ones
  • alphabetizes integration test data template by plugin

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@arturshadnik arturshadnik requested a review from a team as a code owner December 18, 2024 21:05
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. new-feature Net-new feature labels Dec 18, 2024
Signed-off-by: Artur Shad Nik <37195151+arturshadnik@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 60.41667% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/components/validator.go 60.41% 25 Missing and 13 partials ⚠️
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   49.42%   49.63%   +0.21%     
==========================================
  Files          46       45       -1     
  Lines        8101     8004      -97     
==========================================
- Hits         4004     3973      -31     
+ Misses       3231     3189      -42     
+ Partials      866      842      -24     
Files with missing lines Coverage Δ
pkg/components/validator.go 58.61% <60.41%> (+9.09%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa13e2...dc52ddc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TylerGillson
TylerGillson previously approved these changes Dec 19, 2024
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@validator-labs validator-labs deleted a comment from gitguardian Bot Jun 16, 2025
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@TylerGillson TylerGillson self-requested a review June 16, 2025 23:09
@arturshadnik arturshadnik merged commit ccaf318 into main Jun 16, 2025
7 checks passed
@arturshadnik arturshadnik deleted the enh/encoding branch June 16, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer new-feature Net-new feature size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants