feat: replace encryption with b64 encoding#289
Merged
arturshadnik merged 9 commits intomainfrom Jun 16, 2025
Merged
Conversation
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <37195151+arturshadnik@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 49.42% 49.63% +0.21%
==========================================
Files 46 45 -1
Lines 8101 8004 -97
==========================================
- Hits 4004 3973 -31
+ Misses 3231 3189 -42
+ Partials 866 842 -24
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
TylerGillson
previously approved these changes
Dec 19, 2024
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
TylerGillson
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#281
Description
Since the purpose of encrypting secret values was simply to obfuscate, rather than truly encrypt, we can simplify the process by base64 encoding them instead.
This PR:
cryptopkg