TestRunner: write to the messagesFile only at the end.#1891
Merged
sideshowbarker merged 1 commit intovalidator:mainfrom Oct 15, 2025
tenzap:ajaxTestRunner
Merged
TestRunner: write to the messagesFile only at the end.#1891sideshowbarker merged 1 commit intovalidator:mainfrom tenzap:ajaxTestRunner
sideshowbarker merged 1 commit intovalidator:mainfrom
tenzap:ajaxTestRunner
Conversation
Addition/Fix to ff0c83e Since reportedMessages.build() flushes the content of the JsonObjectBuilder it has to be called only once, at the end of the processing.
sideshowbarker
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition/Fix to ff0c83e
Since reportedMessages.build() flushes the content of the JsonObjectBuilder it has to be called only once, at the end of the processing.
After ff0c83e, the resulting
messages.jsonbecame empty when runningmake -C tests/ messages.json. This should fix it.