fix(isLicensePlate): remove duplicate char from character class#2085
fix(isLicensePlate): remove duplicate char from character class#2085profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2085 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
WikiRik
left a comment
There was a problem hiding this comment.
Can you remove the other K for alphabetical order?
|
Sure thing @WikiRik! can you please add the hacktober tag after merge? |
WikiRik
left a comment
There was a problem hiding this comment.
I'm not a maintainer of this repo so I can't add the label but I think the maintainers will keep this in mind for you
profnandaa
left a comment
There was a problem hiding this comment.
Thanks for the fix, good catch!
The str validator had the 'K' char two times in its regexp character class. This PR removes one of them.
ABCDEFH
KIJKLMNPRSTUVXYZ -> ABCDEFHIJKLMNPRSTUVXYZChecklist