feat(isMobilePhone): add Brunei phone validation (#1761)#2704
Open
lrg913427-dot wants to merge 1 commit intovalidatorjs:masterfrom
Open
feat(isMobilePhone): add Brunei phone validation (#1761)#2704lrg913427-dot wants to merge 1 commit intovalidatorjs:masterfrom
lrg913427-dot wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Add mobile phone validation for Brunei (ms-BN) with country code +673. Mobile numbers in Brunei start with 7 or 8 followed by 6 digits. - Add regex pattern to src/lib/isMobilePhone.js - Add test cases in test/validators.test.js - Update README.md locale list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds mobile phone validation for Brunei (locale:
ms-BN, country code:+673) to address issue #1761.Changes
src/lib/isMobilePhone.js: Added regex pattern^(\+?673)?[78]\d{6}$forms-BNlocaletest/validators.test.js: Added test cases with valid and invalid phone numbers for BruneiREADME.md: Addedms-BNto the locale list forisMobilePhonePhone number format
+6737123456,7123456,8123456Testing
All 318 tests pass with 100% statement and line coverage.
Fixes #1761