Enable custom URLs for clipboard copy workaround#1189
Conversation
|
Pull requests must include at least one of the required labels: |
There was a problem hiding this comment.
This worked after I did the Developer Tools > Empty Cache & Hard Reload thing, before it gave me this:
So to user-proof this, I added commit #8eb6376 which does the emptying & hard-refreshing when users click the refresh page button.
Lighthouse check resultsShow Lighthouse scoresFolder depth level checked: 0 Commit SHA: 65c9bfc Modify the workflow to check a different depth:
|
PR SummaryThis PR introduces two primary enhancements:
Test Suggestions
|
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
Thank you, @validbeck! I did not see this behaviour but I appreciate you adding a nocache directive to help our users. 🫶 |
* Enable custom URLs for copy-clipboard workaround * Empty cache & hard refresh on login pages --------- Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Cherry pick: Enable custom URLs for clipboard copy workaround (#1189)
Pull Request Description
What and why?
The
rewriteUrls()function invmurl-settings.jsrewrites URLs in:section[data-background-iframe]attributes (background iframes)a[href]attributes (links)But the function does not rewrite
iframe[src]attributes, so the hardcoded URLs in _get-your-code-snippet.qmd and _retrieve-your-code-snippet.qmd are never updated when users set a custom URL.This PR adds iframe src rewriting to the
rewriteUrls()function, following the same pattern as existing rewrites.How to test
Proof it works:
The custom URL is set to
https://app.dev.vm.validmind.ai/, pointing to our dev environment instead of prod.A page that embeds _get-your-code-snippet.qmd:
https://app.dev.vm.validmind.ai/A page that embeds _retrieve-your-code-snippet.qmd:
https://app.dev.vm.validmind.ai/What needs special review?
N/A
Dependencies, breaking changes, and deployment notes
None
Release notes
N/A — internal training slides update
Checklist