Training slides: Remove nocache directive and sanitize custom URLs#1193
Training slides: Remove nocache directive and sanitize custom URLs#1193
Conversation
Use location.reload(true) instead of appending a nocache query parameter to fix odd behavior observed in production. Related: #1192
Sanitize URLs in setCustomUrl to prevent issues with URL replacement.
PR SummaryThis PR introduces two key enhancements:
Test Suggestions
|
Lighthouse check resultsShow Lighthouse scoresFolder depth level checked: 0 Commit SHA: 7d6a626 Modify the workflow to check a different depth:
|
Validate docs site✓ INFO: A live preview of the docs site is available — Open the preview |
validbeck
left a comment
There was a problem hiding this comment.
This seems to work as expected, as far as I can tell.
Pull Request Description
What and why?
Applies fixes from #1192 (merged to prod) to main, plus an additional improvement:
location.reload(true)to fix odd behavior observed in the training login slides.How to test
https://app.dev.vm.validmind.ai/)./:Which can lead to 404s due to a double
//:/:Which renders as expected:
What needs special review?
N/A — straightforward changes already validated in prod.
Dependencies, breaking changes, and deployment notes
None.
Release notes
N/A — internal fix.
Checklist