Added scroll-padding-top to offset anchors for fixed nav
#240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pull requests must include at least one of the required labels: |
nrichers
requested changes
Jul 4, 2024
Collaborator
nrichers
left a comment
nrichers
left a comment
There was a problem hiding this comment.
This PR does a nice job of fixing the anchor offset issue we were having. My only request would be that we not add highlighting around link targets, I don't think it adds anything that a user would need to know.
nrichers
approved these changes
Jul 5, 2024
Collaborator
nrichers
left a comment
nrichers
left a comment
There was a problem hiding this comment.
My apologies for asking you to remove the cool pink colours from the PR. (Just commented them out, eh? 😁 )
Boring people say LGTM! 
validbeck
deleted the
beck/sc-4381/anchor-links-on-docs-site-offset-incorrectly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
Span highlighting
I adjusted the
<span>anchors I found to have this neat highlighting that draws attention to the active span!