Skip to content

Conversation

@validbeck
Copy link
Collaborator

Internal Notes for Reviewers

For sc-4768, I:

  • Created a net-new page discussing working with test results (& viewing their metadata): developer/model-documentation/work-with-test-results.qmd
  • Retooled developer/model-documentation/generate-model-documentation.qmd to have a cleaned up workflow only (with much less confusing instructions!)
  • Then, created a new landing page (developer/model-documentation/generating-model-documentation.qmd) for the conceptual workflow overview and shoved all the relevant articles under here

Work with test results

  • This page expands on some of the content from "Work with content blocks" — which I cleaned up a little to link out to this guide for test-driven blocks instead of having a section of confusing conditional instructions.
  • After laying the foundation I then expanded on how to view the test result metadata
Add test results View test result metadata
Screenshot 2024-08-22 at 10 01 36 AM Screenshot 2024-08-22 at 9 53 11 AM

Work with content blocks

Since there's now an extended guide on test-driven blocks, I simplified this general context blocks guide to make room for a later potential overview of the text editor.

Old New
Screenshot 2024-08-22 at 10 03 19 AM Screenshot 2024-08-22 at 9 53 24 AM

Generate model documentation

  • The old version of this page was a bit clunky, and the instructions jumped back and forth and were a bit hard to follow. I broke down the workflow into the overview and the actual instructions, then cleaned up the instructions to be hopefully a bit more parsable.
Old New
Screenshot 2024-08-22 at 10 13 58 AM Screenshot 2024-08-22 at 9 52 23 AM

Generating model documentation

  • This is the new conceptual overview page, cleaned up, serving as the landing for all the articles relevant to the documentation generation workflow.
  • The initial version of this guide was named "Model documentation workflow" but I think the action gerund is a bit clearer.
Old New
Screenshot 2024-08-22 at 10 14 41 AM Screenshot 2024-08-22 at 10 27 08 AM
Screenshot 2024-08-22 at 10 14 50 AM Screenshot 2024-08-22 at 9 51 33 AM

Other additions & cleanup

Install and initialize the developer framework > Install and initialize ValidMind

  • I noticed that when wrapped in a breadcrumb the variable is bœrked... not great, and while playing around with just plain text I think just using the simple product name is snappier, and sort of hammers home the "cohesion" element of the framework / UI being two pieces of the same puzzle.
Old New
Screenshot 2024-08-22 at 9 40 29 AM Screenshot 2024-08-22 at 9 52 32 AM

Get started

  • Fixed up the developer/get-started-developer-framework.qmd to have the new "Generating model documentation" at the bottom and made the listings look a bit more uniform
Old New
Screenshot 2024-08-22 at 10 11 31 AM Screenshot 2024-08-22 at 9 37 33 AM

Navigation drop-down

  • Added the new "Generating model documentation" landing to the developer framework drop-down
Old New
Screenshot 2024-08-22 at 10 10 40 AM Screenshot 2024-08-22 at 10 08 36 AM

Prerequisties

  • I cleaned up the prereq sections for all the guides under "Generating model docuemntation"

Please note I noticed the extra comma while I was capping for this section, so if you see it in any other screenshots it's been resolved!

Old New
Screenshot 2024-08-22 at 10 18 32 AM Screenshot 2024-08-22 at 10 22 47 AM
Screenshot 2024-08-22 at 10 23 07 AM Screenshot 2024-08-22 at 10 23 02 AM

Jupyter notebooks > Jupyter Notebooks

  • I thought I had already changed this, but the actual proper noun (according to JH website) is "Jupyter Notebooks" so I've just adjusted our verbiage to match that.

@validbeck validbeck added the internal Not to be externalized in the release notes label Aug 22, 2024
@validbeck validbeck self-assigned this Aug 22, 2024
@validbeck
Copy link
Collaborator Author

Hi @even-steven! Just wanted to check in with you that these instructions are accurate:

Add test results View test result metadata
Screenshot 2024-08-22 at 10 01 36 AM Screenshot 2024-08-22 at 9 53 11 AM

@even-steven
Copy link

Hi @even-steven! Just wanted to check in with you that these instructions are accurate:

Add test results View test result metadata
Screenshot 2024-08-22 at 10 01 36 AM Screenshot 2024-08-22 at 9 53 11 AM

Hey @validbeck, looks great! One thing that might be worth mentioning is that Validators in the model can add test-driven blocks within Validation Reports and Developers can add test-driven blocks within the Documentation.

Very nice 👏🏽

@validbeck
Copy link
Collaborator Author

Thanks @even-steven, that's definitely info I didn't have!

Screenshot 2024-08-22 at 1 25 51 PM

@github-actions
Copy link
Contributor

PR Summary

This pull request introduces several enhancements to the model documentation and developer guide for the ValidMind platform. The key changes include:

  1. New Documentation Section: Added a new section for 'Generating Model Documentation' in the developer guide, providing a detailed workflow for generating, refining, and submitting model documentation.
  2. Updated Navigation: Updated the _quarto.yml file to include links to the new documentation sections and reorganized the structure for better navigation.
  3. Content Updates: Made several content updates across multiple files to improve clarity and accuracy, including fixing typos and updating terminology (e.g., 'Jupyter notebook' to 'Jupyter Notebook').
  4. Prerequisites and Permissions: Added detailed prerequisites and permissions information to various documentation files to ensure users have the necessary access and setup before proceeding with tasks.
  5. Code Snippet Updates: Updated code snippets and instructions for initializing the ValidMind developer framework, ensuring they are accurate and up-to-date.
  6. Footnotes and References: Added and updated footnotes and references to guide users to relevant sections and external resources.
  7. Visual Aids: Included new images and GIFs to visually demonstrate steps in the documentation, enhancing user understanding.

These changes aim to improve the overall user experience by providing clearer, more comprehensive, and visually aided documentation for model developers using the ValidMind platform.

Test Suggestions

  • Verify that the new 'Generating Model Documentation' section is accessible from the navigation menu and displays correctly.
  • Check all links in the updated _quarto.yml file to ensure they point to the correct documentation sections.
  • Test the updated code snippets for initializing the ValidMind developer framework to ensure they work as expected.
  • Review the new images and GIFs to ensure they are correctly displayed and relevant to the content.
  • Ensure that all added prerequisites and permissions information is accurate and helps users set up their environment correctly.
  • Check for any broken links or references in the updated documentation files.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR moves the needle on some protracted content structure issues we have in our developer doumentation. Very nice!

I am going to request some changes, mainly to debunk some of our topic titles further and to sort out the section numbering (happy to chat more if you think it would be useful).

validbeck and others added 3 commits August 22, 2024 16:02
…ion.qmd

Co-authored-by: Nik Richers <nik@validmind.ai>
…n.qmd

Co-authored-by: Nik Richers <nik@validmind.ai>
@validbeck
Copy link
Collaborator Author

Changes:

Screenshot 2024-08-22 at 4 28 40 PM Screenshot 2024-08-22 at 4 29 06 PM Screenshot 2024-08-22 at 4 29 20 PM

@validbeck validbeck requested a review from nrichers August 22, 2024 23:30
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after your latest revisions. Thank you! 🚀

@validbeck validbeck merged commit 50004cd into main Aug 22, 2024
@validbeck validbeck deleted the beck/sc-4768/documentation-display-result-metadata-on branch August 22, 2024 23:38
@validbeck validbeck restored the beck/sc-4768/documentation-display-result-metadata-on branch August 22, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants