Skip to content

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Oct 10, 2024

Internal Notes for Reviewers

  • min-height for hero banner so it doesn't get cut off on wider screens
  • Removed the extraneous images in the role sections and added some For lead-in text

LIVE PREVIEW

@validbeck validbeck added the internal Not to be externalized in the release notes label Oct 10, 2024
@validbeck validbeck self-assigned this Oct 10, 2024
@validbeck validbeck requested a review from nrichers October 10, 2024 19:49
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces changes to the site/index.qmd and site/styles.css files. The main functional changes include:

  1. Image Display: The images for administrators, model developers, and model validators have been commented out, preventing them from being displayed on the index page. This change is likely intended to improve page load times or to temporarily hide these images while they are being updated or replaced.

  2. Text Formatting: The text labels for administrators, model developers, and model validators have been updated to a more descriptive format, changing from [administrators] to [for administrators], and similarly for the other roles. This change enhances clarity and readability.

  3. CSS Styling: A new CSS rule has been added to the site/styles.css file, setting a min-height of 600px for certain preformatted text blocks. This change ensures a consistent minimum height for these elements, which can improve the visual layout of the page.

Test Suggestions

  • Verify that the images for administrators, model developers, and model validators are not displayed on the index page.
  • Check that the text labels for administrators, model developers, and model validators are updated correctly and displayed as 'for administrators', 'for model developers', and 'for model validators'.
  • Ensure that the minimum height of 600px is applied to the specified preformatted text blocks and that it does not negatively impact the layout on different screen sizes.
  • Test the page on various browsers to ensure consistent rendering of the changes.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you for making these changes, looks great in the preview.

@validbeck validbeck merged commit 86e02b6 into main Oct 10, 2024
@validbeck validbeck deleted the beck/index-editing branch October 10, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants