Added new introductory validation notebooks#689
Conversation
|
A PR preview is available: Preview URL |
|
Changed references to the API to "ValidMind Library Python API" here as well, and updated the variable to match: documentation/site/_variables.yml Line 22 in db08c00
EDIT: Actually, we probably want to keep mini drop-down with "Python Library," right? hmm.... |
PR SummaryThis pull request introduces several enhancements and bug fixes to the ValidMind documentation and testing framework. The key changes include:
Overall, these changes aim to enhance the usability, clarity, and security of the ValidMind framework, making it easier for users to implement and document their models effectively. Test Suggestions
|
|
A PR preview is available: Preview URL |
2 similar comments
|
A PR preview is available: Preview URL |
|
A PR preview is available: Preview URL |
nrichers
left a comment
There was a problem hiding this comment.
LGTM! Great PR. 🥳
You may notice that I also applied the styling that the API docs have ... (BONUS: This also takes care of the really squished long-titles we have for notebooks!)
I quite appreciate this change and I agree that the styling is preferable, so thank you. 💖
We also have an issue with long sidebar entries in the rest of the docs site that frequently cause wrapping. I would be amenable to applying the same styling from the API reference elsewhere, so it is consistent throughout the site. (Not in this PR, but as a future improvement.)
* Documentation: Manage model stakeholder types (#686) * Draft for stakeholder types * Cleanup model stakeholder types * Added stakeholder instructions to edit fields * Editing * Quick adjust * Quick adjust x2 * Added new introductory validation notebooks (#689) * Pulled in latest from validmind-library @ HEAD * Modified developer portal to have python api css * Testing get-source on new metadata file * Draft for moved developer sidebar * Edited listing tiles * Adjusted wording for developer portal * Reverting old developer notebook to main for training * Tweak * Editing terminology * Latest from library & revering mini drop-down * Reverting old developer notebook to main for training again * User guide updates for attestation (#687) * Initial draft of attestation docs * Lowercase terms * Switch variable * Turn callout into body text * Update submit for review step * Turn callouts into body text and add step * Turn callout into step * Turn margin callout into body text * Simplify process explanation * Direct users to section under settings * Add paragraph about planning attestation periods * Add icons, fix color * Update site/guide/attestation/working-with-attestations.qmd Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com> * Add step about hovering over attestation schedule & add missing play icon --------- Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com> --------- Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@validbeck a similar story here — while debugging my new script to generate release notes, I was trying to figure out why it was skipping docs updates. Not only are these changes not internal, they are should likely also be labelled with |
|
cc: @nrichers These should be surfaced in the release notes alongside the actual release for the notebooks. Please refer to the external release notes on the notebook PR here: |


Internal Notes for Reviewers
LIVE PREVIEW
ValidMind for model validation notebooks
These were added to the "developer" (now library) portal:
ValidMind for model development notebooks
These have the updated numbering structure:
Developers > ValidMind Library
_sidebar.yaml:documentation/site/developer/_sidebar.yaml
Line 3 in a89901c
documentation/site/_quarto.yml
Line 5 in a89901c
ValidMind Library API
There is a sibling PR to this to change the reference to include the API in the title/link for that landing page as this was somehow missed in the initial one — again, trying to reduce confusion with our habit of naming pages/sections the same darn thing!
validmind/validmind-library#350
Introduction for model developers
This old notebook and its executed version I reverted to
main(documentationside only) as we haven't yet updated our training to be able to get rid of the notebook — working on it.validmind.com
I removed this link from the main top navigation as it doesn't need to feature so heavily when it's also in the footer, based on discussions we had during the homepage redesign.