Skip to content

Added new introductory validation notebooks#689

Merged
validbeck merged 11 commits intomainfrom
beck/sc-9191/add-new-validmind-for-model-validation-notebooks
Apr 10, 2025
Merged

Added new introductory validation notebooks#689
validbeck merged 11 commits intomainfrom
beck/sc-9191/add-new-validmind-for-model-validation-notebooks

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Apr 9, 2025

Internal Notes for Reviewers

sc-9191

LIVE PREVIEW

ValidMind for model validation notebooks

These were added to the "developer" (now library) portal:

Sidenav Listing tiles
Screenshot 2025-04-09 at 2 36 33 PM Screenshot 2025-04-09 at 2 36 29 PM

ValidMind for model development notebooks

These have the updated numbering structure:

Sidenav Listing tiles
Screenshot 2025-04-09 at 2 36 23 PM Screenshot 2025-04-09 at 2 36 19 PM

Developers > ValidMind Library

  • Since this portal is much more than a developer portal, I've made the language and links surrounding the portal more universal:
Main drop-down Collapsed drop-down
Screenshot 2025-04-09 at 2 35 39 PM Screenshot 2025-04-09 at 2 34 21 PM
  • You may notice that I also applied the styling that the API docs have to this and the notebooks/test descriptions, since it's jarring for the two sections to have different side navigations (BONUS: This also takes care of the really squished long-titles we have for notebooks!):
Screenshot 2025-04-09 at 2 37 38 PM
  • I also moved the sidebar for this landing section to its own _sidebar.yaml:

- id: validmind-library

- developer/_sidebar.yaml

ValidMind Library API

There is a sibling PR to this to change the reference to include the API in the title/link for that landing page as this was somehow missed in the initial one — again, trying to reduce confusion with our habit of naming pages/sections the same darn thing!

validmind/validmind-library#350

Screenshot 2025-04-09 at 2 35 20 PM

Introduction for model developers

This old notebook and its executed version I reverted to main (documentation side only) as we haven't yet updated our training to be able to get rid of the notebook — working on it.

validmind.com

I removed this link from the main top navigation as it doesn't need to feature so heavily when it's also in the footer, based on discussions we had during the homepage redesign.

Main nav Collapsed nav
Screenshot 2025-04-09 at 2 34 16 PM Screenshot 2025-04-09 at 2 34 21 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Apr 9, 2025
@validbeck validbeck self-assigned this Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

A PR preview is available: Preview URL

@validbeck validbeck requested a review from nrichers April 9, 2025 22:01
@validbeck
Copy link
Collaborator Author

validbeck commented Apr 9, 2025

Changed references to the API to "ValidMind Library Python API" here as well, and updated the variable to match:

api: "ValidMind Library Python API"

Screenshot 2025-04-09 at 4 34 18 PM Screenshot 2025-04-09 at 4 34 25 PM

EDIT: Actually, we probably want to keep mini drop-down with "Python Library," right? hmm....

@validbeck validbeck requested a review from nrichers April 9, 2025 23:36
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR Summary

This pull request introduces several enhancements and bug fixes to the ValidMind documentation and testing framework. The key changes include:

  1. Documentation Updates:

    • Updated various documentation files to improve clarity and consistency, particularly in the ValidMind Library and its usage.
    • Added new sections and examples to the documentation, including detailed guides on setting up and using the ValidMind Library for model validation and development.
    • Enhanced the documentation for custom tests and external test providers, providing clearer instructions and examples.
  2. Testing Enhancements:

    • Introduced new tests and updated existing ones to cover more scenarios, particularly in the areas of model validation and data quality.
    • Improved the test descriptions and added more detailed explanations for test parameters and expected outcomes.
    • Added new test files and updated existing ones to ensure comprehensive coverage of the ValidMind functionalities.
  3. Code Improvements:

    • Refactored code to improve readability and maintainability, including better organization of test files and documentation.
    • Fixed minor bugs and inconsistencies in the codebase, particularly in the test execution and logging mechanisms.
  4. Security and Compliance:

    • Updated security-related documentation to ensure compliance with best practices and standards.
    • Improved the handling of sensitive data in test results and logging, ensuring that sensitive information is not exposed inadvertently.

Overall, these changes aim to enhance the usability, clarity, and security of the ValidMind framework, making it easier for users to implement and document their models effectively.

Test Suggestions

  • Run all updated and new tests to ensure they pass successfully.
  • Verify that the documentation changes are correctly reflected in the rendered output.
  • Check the integration of new test files with the existing test suite.
  • Ensure that the new documentation examples work as expected when followed step-by-step.
  • Test the logging and handling of sensitive data to ensure compliance with security standards.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

A PR preview is available: Preview URL

2 similar comments
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great PR. 🥳

You may notice that I also applied the styling that the API docs have ... (BONUS: This also takes care of the really squished long-titles we have for notebooks!)

I quite appreciate this change and I agree that the styling is preferable, so thank you. 💖

We also have an issue with long sidebar entries in the rest of the docs site that frequently cause wrapping. I would be amenable to applying the same styling from the API reference elsewhere, so it is consistent throughout the site. (Not in this PR, but as a future improvement.)

@validbeck validbeck merged commit fab3481 into main Apr 10, 2025
3 checks passed
@validbeck validbeck deleted the beck/sc-9191/add-new-validmind-for-model-validation-notebooks branch April 10, 2025 20:05
nrichers added a commit that referenced this pull request Apr 11, 2025
* Documentation: Manage model stakeholder types (#686)

* Draft for stakeholder types

* Cleanup model stakeholder types

* Added stakeholder instructions to edit fields

* Editing

* Quick adjust

* Quick adjust x2

* Added new introductory validation notebooks (#689)

* Pulled in latest from validmind-library @ HEAD

* Modified developer portal to have python api css

* Testing get-source on new metadata file

* Draft for moved developer sidebar

* Edited listing tiles

* Adjusted wording for developer portal

* Reverting old developer notebook to main for training

* Tweak

* Editing terminology

* Latest from library & revering mini drop-down

* Reverting old developer notebook to main for training again

* User guide updates for attestation (#687)

* Initial draft of attestation docs

* Lowercase terms

* Switch variable

* Turn callout into body text

* Update submit for review step

* Turn callouts into body text and add step

* Turn callout into step

* Turn margin callout into body text

* Simplify process explanation

* Direct users to section under settings

* Add paragraph about planning attestation periods

* Add icons, fix color

* Update site/guide/attestation/working-with-attestations.qmd

Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>

* Add step about hovering over attestation schedule & add missing play icon

---------

Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>

---------

Co-authored-by: Beck <164545837+validbeck@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nrichers
Copy link
Collaborator

@validbeck a similar story here — while debugging my new script to generate release notes, I was trying to figure out why it was skipping docs updates. Not only are these changes not internal, they are should likely also be labelled with highlight.

@validbeck
Copy link
Collaborator Author

cc: @nrichers

These should be surfaced in the release notes alongside the actual release for the notebooks. Please refer to the external release notes on the notebook PR here:

validmind/validmind-library#348

@nrichers nrichers added documentation Improvements or additions to documentation and removed internal Not to be externalized in the release notes labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants