Skip to content

Use input_id to track inputs being accessed#2

Merged
cachafla merged 3 commits into
release-v1from
cachafla/sc-3403/input-metadata-is-not-logged-correctly
Feb 28, 2024
Merged

Use input_id to track inputs being accessed#2
cachafla merged 3 commits into
release-v1from
cachafla/sc-3403/input-metadata-is-not-logged-correctly

Conversation

@cachafla
Copy link
Copy Markdown
Contributor

@cachafla cachafla commented Feb 28, 2024

Internal Notes for Reviewers

  • Fixes a bug where input metadata was not tracked correctly due to not relying on input_id for looking up inputs

External Release Notes

  • Fixes a bug where input metadata was not tracked correctly due to not relying on input_id for looking up inputs

@shortcut-integration
Copy link
Copy Markdown

This pull request has been linked to Shortcut Story #3403: Input metadata is not logged correctly.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 28, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

Pull requests must include at least one of the required labels: internal, highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

@cachafla cachafla added the bug Something isn't working label Feb 28, 2024
Copy link
Copy Markdown
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix 🙏

@cachafla cachafla merged commit 76e3094 into release-v1 Feb 28, 2024
@cachafla cachafla deleted the cachafla/sc-3403/input-metadata-is-not-logged-correctly branch February 28, 2024 01:38
validbeck added a commit that referenced this pull request May 26, 2026
validbeck added a commit that referenced this pull request May 26, 2026
* Replace developer-framing Key concepts across 31 notebooks

Replay of ef4dba7 + aa4ab2e + 055042e on fresh main, accounting for
PR #509 file renames. Updates the developer-framing Key concepts block
to the new record/model/document terminology across 30 Jupyter
notebooks and 1 R notebook. Includes the cross-framing swap for
qualitative_text_generation.ipynb and the structural restructure (with
preserved architecture images) for use_dataset_model_objects.ipynb.
TOC anchors preserved where present.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Replace validator-framing Key concepts across 4 notebooks

Replay of 4ae2f0a on fresh main, accounting for PR #509 file renames.
Updates the validator-framing Key concepts block to the new
record/model/validation report terminology across 4 validator notebooks
(_about-validmind-validators, quickstart_validation,
1-set_up_validmind_for_validation, validate_application_scorecard).
Adds the new `artifacts (findings)` term. TOC anchor preserved on
validate_application_scorecard.ipynb.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Replace monitoring-framing Key concepts across 3 notebooks

Replay of 421200b on fresh main. Updates the monitoring-framing Key
concepts block to the new record/model/ongoing monitoring report
terminology across 3 monitoring notebooks (_about-validmind-monitoring,
application_scorecard_ongoing_monitoring,
quickstart_customer_churn_ongoing_monitoring). Adds the new
`ongoing monitoring report` and `monitoring template, monitoring
report template` terms. TOC anchors preserved where present.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Edit for beck/sc-15992/documentation-primary-record-types-glossary

* oops

* Updating key concepts for SR 26-2

* Edit #1

* Edit #2

* Edit #3

* ...

* hdfkg

* esfhjks

* omg

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants