Conversation
juanmleng
approved these changes
Jan 30, 2025
Contributor
juanmleng
left a comment
There was a problem hiding this comment.
It looks great Beck! I just left a tiny suggestion.
8d38ffa to
caf2686
Compare
Contributor
PR SummaryThis pull request enhances the
These changes aim to improve the user experience by offering a comprehensive guide to monitoring model performance and detecting potential issues through systematic metric logging. Test Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
1st phase for the documentation of being able to set unit metric thresholds. I cleaned up our "Log metric over time" notebook so I can reference it in our documentation site: https://github.com/validmind/validmind-library/blob/beck/sc-8186/documentation-support-threshold-lines-in/notebooks/how_to/log_metrics_over_time.ipynb
Part 2 is slotting in a reference to it here on the Work with metrics over time guide replacing the "Intro to Unit Metrics" link: validmind/documentation#633