-
Notifications
You must be signed in to change notification settings - Fork 3
notebooks & notebook templating: Removed references to selecting use cases & added missing templates #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebooks & notebook templating: Removed references to selecting use cases & added missing templates #474
Conversation
AnilSorathiya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @validbeck!
|
I received an error about Replace this: by this: |
|
Also I noticed that |
juanmleng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look awesome @validbeck ! I just a couple of minor comments.
PR SummaryThis PR introduces several improvements across the project. First, the Makefile now executes the notebook template generation script via Poetry instead of a direct Python call, standardizing the environment for running scripts. New and updated YAML templates have been added for various documentation aspects such as Capital Markets, Code Explainer, and Gen AI RAG. These templates provide detailed sections covering metadata, model design, testing, data preparation, model evaluation, and monitoring/governance, which will help ensure consistency across documentation notebooks. Multiple notebooks, across areas like credit risk, NLP/LLM, time series, and more, have been updated to remove redundant example texts for model registration. These changes streamline the instructions by removing hard-coded use case examples and improving template name consistency. Additionally, the e2e_template.py script has been enhanced by adding filename normalization—replacing spaces with underscores and converting names to lowercase—which improves usability and consistency when creating new notebooks. A block of code handling the '{use-case}' replacement was also simplified and removed, reducing complexity without affecting the core functionality. Test Suggestions
|
Done in 37f071e!
Spaces are turned into underscores in c265e6f. It now also normalises any capitals if entered, and removes any spaces from the end of the filename if entered as well. |
Pull Request Description
What and why?
I removed the prompt for inserting a sample use case from the notebook generation template and any references to use cases from notebooks as this isn't necessarily a required field on registration depending on organization settings
I added some YAML uploads for templates referenced in notebooks that aren't by default part of organizations and instructions on how to ask customer admins to include these templates for use. For example:
How to test
make notebookand the end-to-end notebook (notebooks/templates/e2e-notebook.ipynb) to make sure it doesn't insert empty use casesWhat needs special review?
Please make sure that the templates I added look accurate.
Dependencies, breaking changes, and deployment notes
n/a
Release notes
n/a
Checklist