Merged
Conversation
strug
reviewed
Mar 5, 2026
src/main/java/dev/vality/analytics/computer/WithdrawalCashFlowComputer.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/vality/analytics/listener/handler/withdrawal/WithdrawalEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/vality/analytics/listener/handler/withdrawal/WithdrawalEventHandler.java
Show resolved
Hide resolved
src/main/java/dev/vality/analytics/listener/handler/withdrawal/WithdrawalEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration-clickhouse/non-sharded/V4__create_withdrawal_table.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration-clickhouse/sharded/V4__create_withdrawal_table.sql
Outdated
Show resolved
Hide resolved
strug
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Для выплат есть необычный для нас requestedAmount (по крайней мере я не помню такого), не увидел причин не оставить его. То есть сумма на момент создания выплаты и фактическая сумма в поле amount.
Еще такой нюанс, что фильтровать по shop в контексте withdrawal нельзя, так что будем только по party.
Словарик по shop таблице надо изменить чтоб фильтр можно было юзать
dictGetString('analytic.shop_dictionary', 'location_url', tuple(partyId, shopId)), ранее там primary key был id и такое не получится эффективно в запросе юзать.Вставка в clickhouse происходит только на status событии, до этого собирается snapshot в posgresql. Таким образом в CH попадают только фактические (финальные) записи. Если у нас партиционирование в топик происходит по withdrawalId (event sourceId), тогда никаких проблем.