TECH-227: Fix routing rules #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a major refactoring to improve routing rules functionality, including the migration from a single observable-resource file to a modular structure, updates to party and shop data handling to use new domain object patterns, and various UI improvements for navigation and data display.
- Refactored observable-resource utilities into separate modules with improved type safety
- Updated party/shop data access patterns to use new domain object structure with
.dataand.refproperties - Enhanced navigation with dynamic labels and improved routing rule links
Reviewed Changes
Copilot reviewed 49 out of 64 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/matez/src/lib/utils/operators/tap-log.ts | Added new RxJS operator for logging values |
| libs/matez/src/lib/utils/operators/filter-operator.ts | Added utility function to filter undefined operators |
| libs/matez/src/lib/utils/observable-resource/ | Split monolithic observable-resource into modular structure |
| libs/matez/src/lib/components/nav/nav.component.ts | Enhanced navigation with checkUrl support for routing rules |
| apps/control-center/src/app/sections/routing-rules/ | Updated routing rules components to use new data patterns |
| apps/control-center/src/app/shared/components/ | Updated table components to use new domain object structure |
| apps/control-center/src/app/api/ | Updated store services to use new observable-resource pattern |
...rty-routing-ruleset/add-party-routing-rule-dialog/add-party-routing-rule-dialog.component.ts
Outdated
Show resolved
Hide resolved
...rty-routing-ruleset/add-party-routing-rule-dialog/add-party-routing-rule-dialog.component.ts
Outdated
Show resolved
Hide resolved
apps/control-center/src/app/api/domain-config/services/domain.service.ts
Outdated
Show resolved
Hide resolved
KeinAsylum
approved these changes
Jul 31, 2025
A77AY
added a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.