Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,12 @@
<dependency>
<groupId>dev.vality</groupId>
<artifactId>damsel</artifactId>
<version>1.685-5c25c2e</version>
</dependency>
<dependency>
<groupId>dev.vality</groupId>
<artifactId>machinegun-proto</artifactId>
<version>1.38-347c5c4</version>
<version>1.43-3decc8f</version>
</dependency>
<dependency>
<groupId>dev.vality</groupId>
Expand All @@ -61,7 +62,7 @@
<dependency>
<groupId>dev.vality</groupId>
<artifactId>reporter-proto</artifactId>
<version>1.16-cc187f5</version>
<version>1.18-d7d9995</version>
</dependency>
<dependency>
<groupId>dev.vality</groupId>
Expand Down Expand Up @@ -203,6 +204,11 @@
<version>3.2.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.springframework.kafka</groupId>
<artifactId>spring-kafka-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.awaitility</groupId>
<artifactId>awaitility</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import org.springframework.cache.annotation.Cacheable;
import org.springframework.stereotype.Service;

import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;

Expand Down Expand Up @@ -56,6 +55,7 @@ public Map<String, ShopConfig> getShopConfigs(String partyId) {
var versionedObjectWithReferences = getPartyObject(partyId);
var shopConfigObjects = versionedObjectWithReferences.getReferencedBy().stream()
.map(VersionedObject::getObject)
.filter(DomainObject::isSetShopConfig)
.map(DomainObject::getShopConfig)
.toList();
log.debug("Receive shops for partyId: {}, shopConfigObjects ='{}'", partyId, shopConfigObjects);
Expand Down
65 changes: 52 additions & 13 deletions src/test/java/dev/vality/reporter/kafka/KafkaListenerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,50 @@
import dev.vality.reporter.config.MockitoSharedServices;
import dev.vality.reporter.model.KafkaEvent;
import dev.vality.reporter.service.impl.InvoicingService;
import dev.vality.testcontainers.annotations.KafkaConfig;
import dev.vality.testcontainers.annotations.kafka.KafkaTestcontainerSingleton;
import dev.vality.testcontainers.annotations.kafka.config.KafkaProducer;
import dev.vality.testcontainers.annotations.postgresql.PostgresqlTestcontainerSingleton;
import org.apache.kafka.clients.producer.KafkaProducer;
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.common.serialization.ByteArraySerializer;
import org.apache.kafka.common.serialization.StringSerializer;
import org.apache.thrift.TBase;
import org.apache.thrift.TSerializer;
import org.apache.thrift.protocol.TBinaryProtocol;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.kafka.config.KafkaListenerEndpointRegistry;
import org.springframework.kafka.listener.MessageListenerContainer;
import org.springframework.kafka.test.EmbeddedKafkaBroker;
import org.springframework.kafka.test.context.EmbeddedKafka;
import org.springframework.kafka.test.utils.ContainerTestUtils;
import org.springframework.test.annotation.DirtiesContext;
import org.springframework.test.context.TestPropertySource;
import org.springframework.test.context.bean.override.mockito.MockitoBean;

import java.time.LocalDateTime;
import java.time.format.DateTimeFormatter;
import java.util.List;
import java.util.Properties;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify;

@SpringBootTest
@KafkaConfig
@DirtiesContext
@KafkaTestcontainerSingleton(
properties = {
"kafka.topics.invoicing.enabled=true",
"kafka.consumer.max-poll-records=1"
},
topicsKeys = "kafka.topics.invoicing.id"
)
@EmbeddedKafka(partitions = 1, topics = "reporter-invoicing-test")
@TestPropertySource(properties = {
"spring.kafka.bootstrap-servers=${spring.embedded.kafka.brokers}",
"spring.kafka.consumer.group-id=reporter-kafka-test",
"kafka.topics.invoicing.id=reporter-invoicing-test",
"kafka.topics.invoicing.enabled=true",
"kafka.consumer.max-poll-records=1"
})
@MockitoSharedServices
@PostgresqlTestcontainerSingleton(excludeTruncateTables = "schema_version")
class KafkaListenerTest {
Expand All @@ -48,16 +60,26 @@ class KafkaListenerTest {
private InvoicingService invoicingService;

@Autowired
private KafkaProducer<TBase<?, ?>> testThriftKafkaProducer;
private EmbeddedKafkaBroker embeddedKafkaBroker;

@Autowired
private KafkaListenerEndpointRegistry kafkaListenerEndpointRegistry;

@Captor
private ArgumentCaptor<List<KafkaEvent>> arg;

@BeforeEach
void waitForKafkaListenersAssignment() {
for (MessageListenerContainer listenerContainer : kafkaListenerEndpointRegistry.getListenerContainers()) {
ContainerTestUtils.waitForAssignment(listenerContainer, embeddedKafkaBroker.getPartitionsPerTopic());
}
}

@Test
void listenInvoicingChanges() throws Exception {
int eventsCount = 1;
for (int i = 0; i < eventsCount; i++) {
testThriftKafkaProducer.send(invoicingTopic, createSinkEvent());
send(invoicingTopic, createSinkEvent());
}
verify(invoicingService, timeout(50000).times(eventsCount))
.handleEvents(arg.capture());
Expand All @@ -82,4 +104,21 @@ private MachineEvent createMessage() {
message.setData(data);
return message;
}

private void send(String topic, TBase<?, ?> event) throws Exception {
try (var producer = new KafkaProducer<String, byte[]>(producerProperties())) {
var serializer = new TSerializer(new TBinaryProtocol.Factory());
producer.send(new ProducerRecord<>(topic, serializer.serialize(event))).get();
producer.flush();
}
}

private Properties producerProperties() {
var properties = new Properties();
properties.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, embeddedKafkaBroker.getBrokersAsString());
properties.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, StringSerializer.class);
properties.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, ByteArraySerializer.class);
properties.put(ProducerConfig.ACKS_CONFIG, "all");
return properties;
}
}
Loading