CI updates#100
Merged
bjosv merged 4 commits intovalkey-io:mainfrom Sep 24, 2024
Merged
Conversation
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
… test Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Perform the punsubscribe before entering non-pubsub mode since Valkey 8 dont allow several UNSUBSCRIBE commands executed under non-pubsub mode. See valkey-io/valkey#759 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
michael-grunder
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Valkey 8 to the compatibility test in CI, which requires the following test update:
Update test of pubsub-replies without a channel/pattern string.
Perform the punsubscribe before entering non-pubsub mode since Valkey 8
dont allow several UNSUBSCRIBE commands executed under non-pubsub mode.
See Decline unsubscribe related command in non-subscribed mode valkey#759
Temporarily use Valkey 7.2.5 in CI for macOS to avoid
error:0A000010F:SSL routines::bad lengtherror in test_throughput. Brew provides Valkey 8.0.0 which fails in our CI runs in main.Primarily use
valkey_versionfrom INFO to determine server version in test.