Create cluster nodes dict and request list when initiating valkeyClusterContext#123
Merged
bjosv merged 2 commits intovalkey-io:mainfrom Oct 23, 2024
Merged
Conversation
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
approved these changes
Oct 23, 2024
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks reasonable. We never free it except in the release function, so there is no chance it can ever be NULL now? I didn't check that OOM test suite with the hard-coded numbers.
Collaborator
Author
Exactly, we only free in the release function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It simplifies the code a bit when these are allocated at context initiation.