Support empty endpoints in redirects#160
Merged
bjosv merged 8 commits intovalkey-io:mainfrom Apr 25, 2025
Merged
Conversation
"An empty endpoint indicates that the server node has an unknown endpoint, and the client should send the next request to the same endpoint as the current request but with the provided port." https://valkey.io/topics/cluster-spec/ Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
approved these changes
Apr 25, 2025
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
The test case looks good. I didn't read all the details but it seems to work.
Comment on lines
+1817
to
+1824
| if ((p = strchr(str, ' ')) != NULL) | ||
| *p = '\0'; | ||
| switch (field++) { | ||
| // Skip field 0, i.e. ASK/MOVED | ||
| case 1: slot = str; break; | ||
| case 2: addr = str; break; | ||
| } | ||
| if (p == NULL) break; /* No more fields. */ |
Collaborator
There was a problem hiding this comment.
Here we check if p is NULL twice. Can we move the switch up and then just do one if-else for p == NULL?
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"An empty endpoint indicates that the server node has an unknown endpoint, and the client should send the next request to the same endpoint as the current request but with the provided port."
https://valkey.io/topics/cluster-spec/