fix ssubscribe command#178
Conversation
96f1d43 to
028ff20
Compare
|
Thanks! In comparison to subscribe and psubscribe the ssubscribe command can return |
|
Yes, you are right. I wanted that MOVED just be returned to users, but seems like a callback is not called in case of error. |
68d0cc5 to
5fab92c
Compare
|
I turned off sharded_pubsub_test in ci-workflows that don’t run clusters |
|
@bjosv Hi! Can we run tests again? |
|
@bjosv Hi! Added error handling and tests. Errors are now returned to users. |
|
Hi @bjosv, could you please rerun the tests again? Last time test passed but after that needed to resolve conflicts |
Sorry, missed it. I will look into your PR a bit more. |
bjosv
left a comment
There was a problem hiding this comment.
Nice, looks like it should work. I just have some change requests about how we need to disable the new tests. I would like that we need to enable them instead. It might be that some users only uses the Makefile and then it might not work when testing with TEST_ASYNC, i.e. changing --skip-cluster-tests to --enable-cluster-tests.
Sorry for slow response; just tell me if your busy then I can make these changes afterwards or so.
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
Signed-off-by: Vyacheslav Vanin <vaninvv@yandex-team.ru>
|
Had to fix some weird Github issue by rebasing and was able to merge now. Thanks. |
Support ssubscribe command
Fixes: #177