Update minimum required CMake version#181
Merged
bjosv merged 2 commits intovalkey-io:mainfrom Mar 21, 2025
Merged
Conversation
Adds a CI job to test that the minimum required CMake version can be used. The CMakeLists.txt currently contains: CMAKE_MINIMUM_REQUIRED(VERSION 3.0.0) Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
CMake 3.7.0 (released Nov. 2016) is required to get FIND_PACKAGE(OpenSSL REQUIRED) to successfully generate the needed target `OpenSSL::SSL`. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
michael-grunder
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 3.7.0 (released Nov. 2016) is required to get
FIND_PACKAGE(OpenSSL REQUIRED)to successfully generate the needed target
OpenSSL::SSL.This PR also adds a CI job to test that the minimum required CMake version can be used.
This showed that building with CMake 3.0 - 3.6 failed.
As reference Ubuntu 18.04 ships with CMake 3.10.