Build complete library#24
Merged
michael-grunder merged 3 commits intovalkey-io:mainfrom Jun 24, 2024
Merged
Conversation
michael-grunder
force-pushed
the
build-complete-library
branch
from
7496b5b to
193bfc8
Compare
bjosv
reviewed
Jun 23, 2024
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Some early comment/questions, but I think it's very good in general.
I'll look at it a bit more.
Move all the libvalkey source files and headers into their final location. * Source files and internal headers in in `src/` * Public headers in `include/valkey/` and `include/valkey/adapters`.
michael-grunder
force-pushed
the
build-complete-library
branch
2 times, most recently
from
cd44982 to
b470de8
Compare
* Update Makefile and CMakeLists.txt to build both standalone and cluster code. * Update dict API to make the API non-static for cluster usage. * Minor changes to a few examples and tests/test.c to get everything compiling. * Use CMake pkg-config .in files in the Makefile Fixes valkey-io#22
michael-grunder
force-pushed
the
build-complete-library
branch
from
b470de8 to
a0fcb70
Compare
bjosv
reviewed
Jun 24, 2024
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
If we fix the following issue in this PR:
/home/runner/work/libvalkey/libvalkey/src/valkeycluster.c:40:10: fatal error: 'valkey/alloc.h' file not found
#include <valkey/alloc.h>
^~~~~~~~~~~~~~~~
by changing to #include "alloc.h" we might already get some green CI jobs.
bjosv
reviewed
Jun 24, 2024
* Use __attribute__((unused)) for the cluster asyn attach static functions. This lets us continue to build with -Werror * Fix the tests target to include ssl objects if needed. * Tweak CI invocation of test.sh * Install valkey-server for tests. * Darwin doesn't have clock_nanosleep * Add a sanity check to test.sh
michael-grunder
force-pushed
the
build-complete-library
branch
from
781507f to
ce9f77b
Compare
Collaborator
Author
|
Non-cluster tests are now passing on Ubuntu, CentOS and RockyLinux. The macOS failures are actually also happening in hiredis so we'll have to investigate what's going on there. I can probably also get a windows VM set up to try and get that building again, but I know nothing about windows. I think we can merge this and then start in on combining the unit tests? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial restructuring of the project to use an idiomatic linux shared object structure.
── examples │ ├── CMakeLists.txt │ └── Makefile │ ├── examples1.c │ ├── examples2.c ├── include │ └── valkey │ ├── adapters │ │ ├── adapter1.h │ │ ├── adapter2.h │ ├── valkey.h │ ├── other-public-headers.h ├── Makefile ├── src │ └── internal.h │ └── sources.c └── tests ├── test.c ├── test1.c └── test.sh