Use a uintptr_t hop for casting pointers to ints#252
Merged
michael-grunder merged 1 commit intovalkey-io:mainfrom Oct 17, 2025
Merged
Use a uintptr_t hop for casting pointers to ints#252michael-grunder merged 1 commit intovalkey-io:mainfrom
michael-grunder merged 1 commit intovalkey-io:mainfrom
Conversation
Fixes valkey-io#251 Signed-off-by: michael-grunder <michael.grunder@gmail.com>
michael-grunder
force-pushed
the
uintptrt-hop
branch
from
839ee9c to
2cb723c
Compare
bjosv
approved these changes
Oct 17, 2025
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Looks good, and I think this can be merged.
cc: @ruihong123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uintptr_thops when converting from pointers to ints.uintptr_tis never larger thanuint64_t(CHERI, maybe?)Fixes #251