Additional overflow protection for MAP/ATTR#292
Merged
michael-grunder merged 1 commit intovalkey-io:mainfrom Mar 11, 2026
Merged
Additional overflow protection for MAP/ATTR#292michael-grunder merged 1 commit intovalkey-io:mainfrom
michael-grunder merged 1 commit intovalkey-io:mainfrom
Conversation
Collaborator
Author
|
The check can be done more concisely but it seemed that clarity was more important. |
bjosv
approved these changes
Mar 10, 2026
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Nice, good finding! A pesky times two..
Maybe line 540 will be the first protection?
There is already overflow protection for multibulk `elements` but the new RESP3 `MAP` and `ATTR` types subsequently double the count. This meant that a malicious or erroneous count of `LLONG_MAX / 2 + 1` would end up overflowing when maxelements = 0. Signed-off-by: michael-grunder <michael.grunder@gmail.com>
michael-grunder
force-pushed
the
fix-map-overflow
branch
from
54badb3 to
af92d1c
Compare
Collaborator
Author
We can put all of the checks on 540 but this seemed easier to reason about. |
michael-grunder
commented
Mar 10, 2026
Collaborator
|
Yes, current state is easy to read. I think it's good to go 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already overflow protection for multibulk
elementsbut the new RESP3MAPandATTRtypes subsequently double the count.This meant that a malicious or erroneous count of
LLONG_MAX / 2 + 1would end up overflowing when maxelements = 0.