Remove support for external dict while still supporting external sds#302
Merged
zuiderkwast merged 3 commits intovalkey-io:mainfrom Apr 16, 2026
Merged
Remove support for external dict while still supporting external sds#302zuiderkwast merged 3 commits intovalkey-io:mainfrom
zuiderkwast merged 3 commits intovalkey-io:mainfrom
Conversation
These two appeared independent, but because they both set include paths, they couldn't be used independently. Instead of fixing that, we just remove the support for using external dict. The reason is that valkey (where libvalkey is vendored and uses external components from valkey's counterpats) has changed the dict implementation so that the API is no longer compatible, but there are no symbol collisions either, so it's fine for libvalkey to use its own dict. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
bjosv
reviewed
Apr 16, 2026
Co-authored-by: Björn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two appeared independent, but because they both set include paths, they couldn't be used independently. Instead of fixing that, we just remove the support for using external dict.
The reason is that valkey (where libvalkey is vendored and uses external components from valkey's counterparts) has changed the dict implementation so that the API is no longer compatible, but there are no symbol collisions either, so it's fine for libvalkey to use its own dict.
Extracted from
valkey-io/valkey@fb655db