Rename and remove deprecated functions in the cluster API#38
Merged
bjosv merged 3 commits intovalkey-io:mainfrom Sep 3, 2024
Merged
Rename and remove deprecated functions in the cluster API#38bjosv merged 3 commits intovalkey-io:mainfrom
bjosv merged 3 commits intovalkey-io:mainfrom
Conversation
bjosv
force-pushed
the
remove-deprecated-functions
branch
from
7d80a67 to
cf9c329
Compare
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
force-pushed
the
remove-deprecated-functions
branch
from
cf9c329 to
9d81e46
Compare
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
These APIs are needed to support PUB/SUB, rename them for public consumption: ctx_get_by_node -> valkeyClusterGetValkeyContext actx_get_by_node -> valkeyClusterGetValkeyAsyncContext Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
changed the title
zuiderkwast
reviewed
Sep 2, 2024
Collaborator
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks good!
Do you want to update the docs markdown file in the same PR?
We should remember this change for the migration guide. We could create a label for the PR for that.
Collaborator
Author
|
The current docs don't mention |
Collaborator
|
How is this a breaking change? We haven't released anything yet. |
zuiderkwast
approved these changes
Sep 3, 2024
bjosv
removed
the
breakingchange
Collaborator
Author
|
Remove label, used it when constructing #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename API functions to get a standalone context from a cluster node, which are needed to support PUB/SUB.
parse_cluster_*functions from the cluster API. Should not be needed by users.