Skip to content

Enable release-drafter in CI#81

Merged
bjosv merged 1 commit intovalkey-io:mainfrom
bjosv:release-drafter
Aug 30, 2024
Merged

Enable release-drafter in CI#81
bjosv merged 1 commit intovalkey-io:mainfrom
bjosv:release-drafter

Conversation

@bjosv
Copy link
Copy Markdown
Collaborator

@bjosv bjosv commented Aug 28, 2024

Enable the release drafter since it was used in hiredis,
and other clients under https://github.com/valkey-io seems keep using it.

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv bjosv requested a review from michael-grunder August 28, 2024 09:21
@bjosv
Copy link
Copy Markdown
Collaborator Author

bjosv commented Aug 29, 2024

I have no experience in using the release-drafter, so I don't really know if its helpful or if we should write the changelog/release notes ourselves..

@michael-grunder
Copy link
Copy Markdown
Collaborator

I like it personally. My biggest issue was forgetting to apply appropriate labels before merging but that's user error 😅

@bjosv
Copy link
Copy Markdown
Collaborator Author

bjosv commented Aug 30, 2024

Ah, then we use it. I'll just have too look into how its works. Hopefully its possible to apply the labels retroactively before we tag and release.

@bjosv bjosv merged commit e5bd195 into valkey-io:main Aug 30, 2024
@bjosv bjosv deleted the release-drafter branch August 30, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants