Skip to content

Remove valkey from filenames and update header guards#88

Merged
bjosv merged 5 commits intovalkey-io:mainfrom
bjosv:header-fixups
Sep 8, 2024
Merged

Remove valkey from filenames and update header guards#88
bjosv merged 5 commits intovalkey-io:mainfrom
bjosv:header-fixups

Conversation

@bjosv
Copy link
Copy Markdown
Collaborator

@bjosv bjosv commented Sep 5, 2024

Since we have change the file structure for public headers we can remove valkey from their filenames.
As example, we will have #include <valkey/ssl.h> instead of #include <valkey/valkey_ssl.h>.

  • valkeycluster.h -> cluster.h
  • valkeycluster_ssl.h -> cluster_ssl.h
  • valkey_rdma.h -> rdma.h
  • valkey_ssl.h -> ssl.h

This PR also includes:

  • The header guards are updated to follow the common rule: <PROJ>_<PATH>_<FILENAME>_H
  • Renaming of 2 cluster source files, removing valkey from their names.
  • Make sure ssl.h can be included before valkey.h (required by clang-format after the rename).

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Comment thread tests/client_test.c
@bjosv bjosv merged commit 8bfb414 into valkey-io:main Sep 8, 2024
@bjosv bjosv deleted the header-fixups branch September 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants