CI updates#95
Merged
bjosv merged 2 commits intovalkey-io:mainfrom Sep 20, 2024
Merged
Conversation
Run the tests under valgrind on Ubuntu only, which *should* be enough. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Makes sure a build without -DNDEBUG is fine. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and move the CI step to build using make.
Run the tests under valgrind on Ubuntu only, which should be enough.
Add a CMake build with type=Debug to make sure building without
-DNDEBUGis fine.