- 
                Notifications
    
You must be signed in to change notification settings  - Fork 95
 
Add documentation for atomic slot migration #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f1617b    to
    0aa162c      
    Compare
  
    Signed-off-by: Jacob Murphy <jkmurphy@google.com>
0aa162c    to
    bb257b9      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly suggesting simplifying. I think the content is pretty good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review; some high-level comments.
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
| 
           Thanks @madolson @zuiderkwast !  | 
    
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits: looks fine otherwise
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Jacob Murphy <jkmurphy@google.com>
Fixes #350