Skip to content

[BUG] Try Valkey broken after Valkey 9.0: No 'Access-Control-Allow-Origin' header is present on the requested resource. #403

@murphyjacob4

Description

@murphyjacob4

Describe the bug

Try Valkey gives a "Failed to load binary" error if you try to Load Emulator

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://valkey.io/try-valkey/
  2. Click on Load Emulator
  3. See error

Expected behavior
Valkey emulator loads

Host/Environment (please complete the following information):

  • OS: MacOS
  • Browser and version: Chrome

Additional context

In the console we see:

Access to XMLHttpRequest at 'https://download.valkey.io/try-me-valkey/9.0.0/states/state.bin.gz' from origin 'https://valkey.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.Understand this error
try-valkey/:350 Error loading binary:  Error checking file version
(anonymous) @ try-valkey/:350Understand this error
try-valkey/:218  HEAD https://download.valkey.io/try-me-valkey/9.0.0/states/state.bin.gz net::ERR_FAILED 304 (Not Modified)
(anonymous) @ try-valkey/:218
checkIfUpdated @ try-valkey/:201
(anonymous) @ try-valkey/:331

In the PR #255 I saw that we may need to configure CORS on some S3 object. Not sure who at AWS has permission to do that (and if we can make it part of the release automation)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions