Update COPY and MOVE command description clearer in JSON file #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hwware <wen.hui.ware@gmail.com>
hwware
force-pushed
the
update-copy-move-command-reply-message-description
branch
from
84036f6 to
a4b5706
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1843 +/- ##
============================================
- Coverage 71.03% 70.85% -0.19%
============================================
Files 123 123
Lines 65666 65671 +5
============================================
- Hits 46648 46530 -118
- Misses 19018 19141 +123 🚀 New features to boost your workflow:
|
Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Wen Hui <wen.hui.ware@gmail.com>
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
…-io#1843) As I do the code review for PR valkey-io#1671 (Add multi-database support to cluster mode), I find the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249 --------- Signed-off-by: hwware <wen.hui.ware@gmail.com> Signed-off-by: Wen Hui <wen.hui.ware@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
ranshid
pushed a commit
to ranshid/valkey
that referenced
this pull request
Mar 31, 2025
…-io#1843) As I do the code review for PR valkey-io#1671 (Add multi-database support to cluster mode), I find the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249 --------- Signed-off-by: hwware <wen.hui.ware@gmail.com> Signed-off-by: Wen Hui <wen.hui.ware@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
ranshid
pushed a commit
that referenced
this pull request
Mar 31, 2025
As I do the code review for PR #1671 (Add multi-database support to cluster mode), I find the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249 --------- Signed-off-by: hwware <wen.hui.ware@gmail.com> Signed-off-by: Wen Hui <wen.hui.ware@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
zarkash-aws
pushed a commit
to zarkash-aws/valkey
that referenced
this pull request
Apr 6, 2025
…-io#1843) As I do the code review for PR valkey-io#1671 (Add multi-database support to cluster mode), I find the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249 --------- Signed-off-by: hwware <wen.hui.ware@gmail.com> Signed-off-by: Wen Hui <wen.hui.ware@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Shai Zarka <zarkash@amazon.com>
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
…-io#1843) As I do the code review for PR valkey-io#1671 (Add multi-database support to cluster mode), I find the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249 --------- Signed-off-by: hwware <wen.hui.ware@gmail.com> Signed-off-by: Wen Hui <wen.hui.ware@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I do the code review for PR #1671 (Add multi-database support to cluster mode), I find
the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249