Update function clusterNodeSetSlotBit() return type to void #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwware
force-pushed
the
update-function-return-type
branch
from
2b911a1 to
78560b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1934 +/- ##
============================================
- Coverage 70.99% 70.86% -0.14%
============================================
Files 123 123
Lines 65769 65768 -1
============================================
- Hits 46693 46604 -89
- Misses 19076 19164 +88
🚀 New features to boost your workflow:
|
xbasel
reviewed
Apr 8, 2025
src/cluster_legacy.c
Outdated
| /* Set the slot bit */ | ||
| void clusterNodeSetSlotBit(clusterNode *n, int slot) { | ||
| int old = bitmapTestBit(n->slots, slot); | ||
| if (!old) { |
Member
There was a problem hiding this comment.
if(!bitmapTestBit(n->slots, slot)) {
Contributor
Author
There was a problem hiding this comment.
Thanks for your comments. It is removed now.
xbasel
reviewed
Apr 8, 2025
src/cluster_legacy.c
Outdated
|
|
||
| /* Set the slot bit and return the old value. */ | ||
| int clusterNodeSetSlotBit(clusterNode *n, int slot) { | ||
| /* Set the slot bit */ |
Member
There was a problem hiding this comment.
Redundant. The function name clusterNodeSetSlotBit already says it.
Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: hwware <wen.hui.ware@gmail.com>
hwware
force-pushed
the
update-function-return-type
branch
2 times, most recently
from
7a7dbe1 to
571cb82
Compare
zuiderkwast
approved these changes
Apr 11, 2025
PingXie
approved these changes
Apr 12, 2025
enjoy-binbin
approved these changes
Apr 12, 2025
hwware
added a commit
to wuranxx/valkey
that referenced
this pull request
Apr 24, 2025
…o#1934) No other functions use the return value of clusterNodeSetSlotBit(), thus this PR update the return type to void and update the comments. --------- Signed-off-by: hwware <wen.hui.ware@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No other functions use the return value of clusterNodeSetSlotBit(), thus this PR update the return type to void and
update the comments.