Skip to content

Update remaning redis to valkey in TLS.md#201

Merged
madolson merged 1 commit intovalkey-io:unstablefrom
hwware:update-TLS-md
Apr 4, 2024
Merged

Update remaning redis to valkey in TLS.md#201
madolson merged 1 commit intovalkey-io:unstablefrom
hwware:update-TLS-md

Conversation

@hwware
Copy link
Copy Markdown
Contributor

@hwware hwware commented Apr 4, 2024

TLS related issues are fixed, but some not.
This PR fix them.

@hwware
Update some redis string to valkey
1bd78b3 
Signed-off-by: hwware <wen.hui.ware@gmail.com>
@hwware hwware requested review from madolson and zuiderkwast April 4, 2024 16:10
madolson
madolson reviewed Apr 4, 2024
View reviewed changes
Comment thread TLS.md
Comment on lines -88 to +93
- [ ] redis-benchmark support. The current implementation is a mix of using
- [ ] valkey-benchmark support. The current implementation is a mix of using
hiredis for parsing and basic networking (establishing connections), but
directly manipulating sockets for most actions. This will need to be cleaned
up for proper TLS support. The best approach is probably to migrate to hiredis
async mode.
- [ ] redis-cli `--slave` and `--rdb` support.
- [ ] valkey-cli `--slave` and `--rdb` support.
Copy link
Copy Markdown
Member

@madolson madolson Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, can you move these to issues instead of a random TODO in the TLS md.

Copy link
Copy Markdown
Contributor Author

@hwware hwware Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me create 2 issues on this

@madolson madolson merged commit a0b0976 into valkey-io:unstable Apr 4, 2024
PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this pull request Apr 24, 2024
@hwware @PatrickJS
Update remaning redis to valkey in TLS.md (valkey-io#201)
add5f4c 
Updated TLS.md to remove references to Redis and replace them with Valkey.

Signed-off-by: hwware <wen.hui.ware@gmail.com>
bjosv added a commit to bjosv/valkey that referenced this pull request Aug 20, 2025
@bjosv
Update deps/libvalkey to version 0.2.1
c140cb9 
Squashed 'deps/libvalkey/' changes from abcd27fbf..d95a5ee9a

9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205)
178e350c7 Cluster code cleanup (valkey-io#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212)
279125e22 Spelling (valkey-io#213)
99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199)
f670346b9 Only install headers for `TLS` and `RDMA` when enabled in CMake (valkey-io#206)
41c5911f1 Remove macro UNUSED from public API (valkey-io#200)
969a8c546 Fix dependency issue with RDMA (valkey-io#201)

git-subtree-dir: deps/libvalkey
git-subtree-split: d95a5ee9ad95b9ee7f298f38d0fb93f3f7659ef7

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv added a commit to bjosv/valkey that referenced this pull request Aug 20, 2025
@bjosv
Update deps/libvalkey to version 0.2.1
128348d 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205)
178e350c7 Cluster code cleanup (valkey-io#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212)
99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199)
969a8c546 Fix dependency issue with RDMA (valkey-io#201)

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv added a commit to bjosv/valkey that referenced this pull request Aug 21, 2025
@bjosv
Update deps/libvalkey to version 0.2.1
564f0aa 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205)
178e350c7 Cluster code cleanup (valkey-io#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212)
99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199)
969a8c546 Fix dependency issue with RDMA (valkey-io#201)
...

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv added a commit to bjosv/valkey that referenced this pull request Aug 21, 2025
@bjosv
Update deps/libvalkey to version 0.2.1
19d531f 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205)
178e350c7 Cluster code cleanup (valkey-io#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212)
99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199)
969a8c546 Fix dependency issue with RDMA (valkey-io#201)
...

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast pushed a commit that referenced this pull request Aug 21, 2025
@bjosv @zuiderkwast
Update deps/libvalkey to version 0.2.1
11780db 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (#205)
178e350c7 Cluster code cleanup (#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (#212)
99aa158bc Use existing connections for blocking slotmap updates (#199)
969a8c546 Fix dependency issue with RDMA (#201)
...

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
rjd15372 pushed a commit to rjd15372/valkey that referenced this pull request Sep 19, 2025
@bjosv @rjd15372
Update deps/libvalkey to version 0.2.1
d11d943 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205)
178e350c7 Cluster code cleanup (valkey-io#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212)
99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199)
969a8c546 Fix dependency issue with RDMA (valkey-io#201)
...

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
rjd15372 pushed a commit that referenced this pull request Sep 23, 2025
@bjosv @rjd15372
Update deps/libvalkey to version 0.2.1
8c5a1c3 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (#205)
178e350c7 Cluster code cleanup (#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (#212)
99aa158bc Use existing connections for blocking slotmap updates (#199)
969a8c546 Fix dependency issue with RDMA (#201)
...

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
hpatro pushed a commit to hpatro/valkey that referenced this pull request Oct 3, 2025
@bjosv @hpatro
Update deps/libvalkey to version 0.2.1
408526d 
Squashed 'deps/libvalkey/' changes from abcd27fbf..b012f8e85

b012f8e85 Release 0.2.1
9e10acbf7 Fix duplicate Acks for RDMA events. (valkey-io#229)
1eadedf48 Remove the unused valDup API from dict
a449f0ea1 Don't expose internal functions in shared libraries (valkey-io#205)
178e350c7 Cluster code cleanup (valkey-io#216)
4020396c8 Fix `unused-parameter` warning when building with `NDEBUG` (valkey-io#212)
99aa158bc Use existing connections for blocking slotmap updates (valkey-io#199)
969a8c546 Fix dependency issue with RDMA (valkey-io#201)
...

git-subtree-dir: deps/libvalkey
git-subtree-split: b012f8e85a9cc2c68bc2be982a4f6545c15042f0

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

@madolson madolson madolson approved these changes

+1 more reviewer

@Shivshankar-Reddy Shivshankar-Reddy Shivshankar-Reddy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hwware @zuiderkwast @madolson @Shivshankar-Reddy