Skip to content

Update COPYING to Valkey#32

Merged
hwware merged 4 commits intovalkey-io:unstablefrom
PatrickJS:patch-1
Apr 24, 2024
Merged

Update COPYING to Valkey#32
hwware merged 4 commits intovalkey-io:unstablefrom
PatrickJS:patch-1

Conversation

@PatrickJS
Copy link
Copy Markdown
Contributor

@PatrickJS PatrickJS commented Mar 26, 2024

Add License Copyright description for Valkey contributors in COPYING

@natoscott
Copy link
Copy Markdown
Contributor

Not appropriate and not legally sound.

Comment thread COPYING Outdated
@PatrickJS
Copy link
Copy Markdown
Contributor Author

PatrickJS commented Mar 26, 2024

Not appropriate and not legally sound.

^ this was because I originally backdated the copyright which was my fault. I updated it to the correct dates


ok, well now this is more correct until the rename (again my vote is OpenKV, OpenKVS)

@PatrickJS
Copy link
Copy Markdown
Contributor Author

@madolson ok everything fixed and signed 🙏

@PatrickJS PatrickJS requested a review from madolson April 1, 2024 02:51
@PatrickJS PatrickJS changed the title Update COPYING Update COPYING to Valkey Apr 1, 2024
@PatrickJS
Copy link
Copy Markdown
Contributor Author

I updated to include both old and new since the old one had Redis in it

* Neither the name of Redis nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.

@hwware
Copy link
Copy Markdown
Contributor

hwware commented Apr 23, 2024

@PatrickJS Please rebase and fix the error in CI, Thanks

@PatrickJS PatrickJS force-pushed the patch-1 branch 2 times, most recently from bfcc6c3 to 36f2ce8 Compare April 24, 2024 03:11
PatrickJS and others added 3 commits April 23, 2024 20:12
Signed-off-by: PatrickJS <github@patrickjs.com>
Signed-off-by: PatrickJS <github@patrickjs.com>
Signed-off-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Co-Authored-By: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Signed-off-by: PatrickJS <github@patrickjs.com>
@PatrickJS
Copy link
Copy Markdown
Contributor Author

PatrickJS commented Apr 24, 2024

@hwware rebased the ci error is likely because the pr was outdated

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.39%. Comparing base (669f1d3) to head (f375269).
Report is 3 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable      #32      +/-   ##
============================================
+ Coverage     68.33%   68.39%   +0.06%     
============================================
  Files           108      108              
  Lines         61562    61562              
============================================
+ Hits          42066    42103      +37     
+ Misses        19496    19459      -37     

see 14 files with indirect coverage changes

@hwware
Copy link
Copy Markdown
Contributor

hwware commented Apr 24, 2024

@madolson do you think we could merge this PR? Thanks

Comment thread COPYING Outdated
Signed-off-by: PatrickJS <github@patrickjs.com>
Signed-off-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Co-Authored-By: Madelyn Olson <madelyneolson@gmail.com>
@PatrickJS
Copy link
Copy Markdown
Contributor Author

@hwware @madolson done

@PatrickJS
Copy link
Copy Markdown
Contributor Author

PatrickJS commented Apr 24, 2024

all green, thanks (I don't have merge button)

@hwware hwware merged commit be81469 into valkey-io:unstable Apr 24, 2024
@PatrickJS PatrickJS deleted the patch-1 branch April 24, 2024 23:06
WM0323 pushed a commit to WM0323/valkey that referenced this pull request Apr 26, 2024
Add License Copyright description for Valkey contributors in COPYING

---------

Signed-off-by: PatrickJS <github@patrickjs.com>
Signed-off-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>

Signed-off-by: Sher Sun <sher.sun@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants