redisbenchmark to valkeybenchmark in test directory and some test name rename.#347
Merged
madolson merged 4 commits intovalkey-io:unstablefrom Apr 23, 2024
Merged
Conversation
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Shivshankar-Reddy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #347 +/- ##
============================================
- Coverage 68.39% 68.36% -0.04%
============================================
Files 108 108
Lines 61562 61555 -7
============================================
- Hits 42107 42081 -26
- Misses 19455 19474 +19 |
madolson
reviewed
Apr 22, 2024
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Contributor
|
LGTM, Thanks |
hwware
approved these changes
Apr 23, 2024
madolson
approved these changes
Apr 23, 2024
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
…e rename. (valkey-io#347) This pr covers following chnages. 1. redisbenchmark to valkeybenchmark in test directory 2. Removed redis from some test's title and changed the name accordingly. 3. Updated test suite name and redis-server to valkey readme in test directory. --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr covers following chnages.