Update links in module API docs (generated from module.c)#433
Merged
zuiderkwast merged 1 commit intovalkey-io:unstablefrom May 3, 2024
Merged
Update links in module API docs (generated from module.c)#433zuiderkwast merged 1 commit intovalkey-io:unstablefrom
zuiderkwast merged 1 commit intovalkey-io:unstablefrom
Conversation
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
zuiderkwast
commented
May 3, 2024
Contributor
Author
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
This is comments used for generated docs. I'm merging.
madolson
reviewed
May 3, 2024
|
|
||
| # Populate the 'since' map (name => version) if we're in a git repo. | ||
| require File.dirname(__FILE__) ++ '/module-api-since.rb' | ||
| require "./" ++ File.dirname(__FILE__) ++ '/module-api-since.rb' |
Contributor
Author
There was a problem hiding this comment.
I don't know ruby that well, but with this change I can call the script regardless of my current directory.
Contributor
Author
There was a problem hiding this comment.
File.dirname(__FILE__) is apparently a relative path.
Member
There was a problem hiding this comment.
Ok, I suppose in fullness of time it should be called from automation.
madolson
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are used in the docs and on the website.