Skip to content

Remove unnecessary clang-format off annotations#628

Merged
zuiderkwast merged 4 commits intovalkey-io:unstablefrom
zuiderkwast:delete-redundant-clang-format-off
Jun 12, 2024
Merged

Remove unnecessary clang-format off annotations#628
zuiderkwast merged 4 commits intovalkey-io:unstablefrom
zuiderkwast:delete-redundant-clang-format-off

Conversation

@zuiderkwast
Copy link
Copy Markdown
Contributor

We added some clang-format off comments before we had decided on the format configuration. Now, it turns out that turning formatting off is often not necessary.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast marked this pull request as draft June 11, 2024 20:17
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 48 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (e65b2d2) to head (a5820ef).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #628      +/-   ##
============================================
+ Coverage     70.11%   70.24%   +0.13%     
============================================
  Files           110      110              
  Lines         60038    60039       +1     
============================================
+ Hits          42096    42175      +79     
+ Misses        17942    17864      -78     
Files Coverage Δ
src/listpack.c 90.65% <100.00%> (-1.00%) ⬇️
src/networking.c 85.37% <100.00%> (-0.05%) ⬇️
src/notify.c 97.01% <100.00%> (ø)
src/object.c 78.57% <100.00%> (ø)
src/replication.c 87.10% <100.00%> (ø)
src/util.c 71.25% <ø> (ø)
src/valkey-cli.c 53.26% <100.00%> (+1.75%) ⬆️
src/sds.c 85.81% <0.00%> (ø)
src/server.c 88.92% <0.00%> (ø)
src/valkey-benchmark.c 57.66% <0.00%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast zuiderkwast marked this pull request as ready for review June 11, 2024 22:54
@zuiderkwast zuiderkwast requested a review from ranshid June 11, 2024 22:57
@zuiderkwast zuiderkwast merged commit 4bb7cc4 into valkey-io:unstable Jun 12, 2024
@zuiderkwast zuiderkwast deleted the delete-redundant-clang-format-off branch June 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants