Fix rdb_child_exit_pipe incorrect close call#801
Merged
PingXie merged 1 commit intovalkey-io:unstablefrom Jul 18, 2024
Merged
Conversation
server.rdb_child_exit_pipe is init in !dual_channel block, so the call here would be close(-1) in !dual_channel way. It will also generate a warning in valgrind: Warning: invalid file descriptor -1 in syscall close() Introduced in valkey-io#60. Signed-off-by: Binbin <binloveplay1314@qq.com>
Member
Author
|
@naglera please also take a look. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #801 +/- ##
============================================
- Coverage 70.44% 70.43% -0.02%
============================================
Files 112 112
Lines 61135 61135
============================================
- Hits 43066 43058 -8
- Misses 18069 18077 +8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server.rdb_child_exit_pipe is init in !dual_channel block,
so the call here would be close(-1) in !dual_channel way.
It will also generate a warning in valgrind:
Warning: invalid file descriptor -1 in syscall close()
Introduced in #60.