feat(carousel): indicators for group of slides #5234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #5233 with indicatorsByChunk input the carousel indicators indicate slides chunks - works ONLY if singleSlideOffset = FALSE
Codecov Report
@@ Coverage Diff @@
## development #5234 +/- ##
============================================
Coverage 51.51% 51.51%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 51 51
Misses 38 38
Partials 10 10Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #5234 +/- ##
===============================================
+ Coverage 51.04% 51.51% +0.47%
===============================================
Files 3 3
Lines 96 99 +3
Branches 17 17
===============================================
+ Hits 49 51 +2
- Misses 37 38 +1
Partials 10 10
Continue to review full report at Codecov.
|
Domainv
approved these changes
Jun 5, 2019
|
Smoke tested in CHrome - looks good. |
Domainv
changed the title
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
Fix: valor-software#5233 with indicatorsByChunk input the carousel indicators indicate slides chunks - works ONLY if singleSlideOffset = FALSE
IraErshova
pushed a commit
to IraErshova/ngx-bootstrap
that referenced
this pull request
Jan 20, 2020
Fix: valor-software#5233 with indicatorsByChunk input the carousel indicators indicate slides chunks - works ONLY if singleSlideOffset = FALSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5233
with indicatorsByChunk input the carousel indicators indicate slides chunks
works ONLY if singleSlideOffset = FALSE