fix(articles): fixed images in adoc articles #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit bd8dcb8): https://valor-software-site--pr89-fixed-adoc-img-se47lm4x.web.app (expires Thu, 30 Jun 2022 14:38:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
valorkin
reviewed
Jun 28, 2022
apps/adoc-article-app/src/main.ts
Outdated
| const extension = path.extname(file.name).split('.')[1]; | ||
| if ( extension === 'adoc') { | ||
| const content = await fs.readFile(`${articlesFolderPath}/${folder.name}/${file.name}`, 'utf8'); | ||
| let content = await fs.readFile(`${articlesFolderPath}/${folder.name}/${file.name}`, 'utf8'); |
There was a problem hiding this comment.
this looks as not obvious solution
valorkin
requested changes
Jun 28, 2022
valorkin
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(articles): fixed images in adoc articles