You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By including $lower in the attributes for dashed it allows for the use cases of generating gift card codes or serial numbers (generally uppercase only) in a more efficient way than using strtoupper afterward.
Currently when $lower is set to true for dashed (the default) both lowercase and uppercase will be used, when it is set to false only uppercase will be used. My goal here was to keep the attribute name consistent with other methods, but thinking about it again this might not be fully clear since one might think $lower as true means lowercase only.
What would you think about renaming this attribute only on dashed to $mixedCase instead of $lower for added clarity? Then when $mixedCase is true both uppercase and lowercase are used, when false only uppercase is used.
Alternatively if keeping the $lower naming consistent is desired, a comment could be added to this method's attribute to explain its behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By including
$lowerin the attributes fordashedit allows for the use cases of generating gift card codes or serial numbers (generally uppercase only) in a more efficient way than usingstrtoupperafterward.