Skip to content

Allow string as input for useSymbols#23

Merged
valorin merged 2 commits into
valorin:mainfrom
princejohnsantillan:use-symbols-from-string
Mar 18, 2025
Merged

Allow string as input for useSymbols#23
valorin merged 2 commits into
valorin:mainfrom
princejohnsantillan:use-symbols-from-string

Conversation

@princejohnsantillan
Copy link
Copy Markdown
Contributor

This allows defining symbols list as a string instead of an array. Makes for better DX.

Example:

Random::useSymbols("A1B2C3D4")->string();

@valorin
Copy link
Copy Markdown
Owner

valorin commented Mar 14, 2025

I love the idea, can you expand it for the other use*() methods?
Also, some tests would be great.

One problem, you can't use array|string with the PHP 7,x versions. Check the failing tests. 🙂

@valorin valorin merged commit 32cd34f into valorin:main Mar 18, 2025
@valorin
Copy link
Copy Markdown
Owner

valorin commented Mar 18, 2025

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants