Fix string length conflict with requireAll#9
Merged
Conversation
noplanman
approved these changes
Jan 1, 2024
Owner
|
Ah nice, thanks! I did consider this issue when I wrote the code, but forgot to do anything about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
To fix the conflict between the
lengthandrequireAll, I make sure that thelengthis enough to require all the types of input. If not it throws an error.Examples
Fatal error: Uncaught InvalidArgumentException: Length not enough to requireAll!In this case it will throw an error because
length = 2is not enough to require all the three (lower,numbersandsymbols)But if we deactivate
numbersso we can have only2, This will work and require bothlowerandsymbols.string(2) "%b"