Update trader to stop after staking KPI met #260
Conversation
| export WXDAI_ADDRESS="0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d" | ||
| export DISABLE_TRADING=false | ||
| export STOP_TRADING_IF_STAKING_KPI_MET=true | ||
| export RESET_PAUSE_DURATION=300 |
There was a problem hiding this comment.
Is this admissible? (300s = 5 minutes)
There was a problem hiding this comment.
Why do you want to override this?
There was a problem hiding this comment.
This ensures that the trader waits 5 minutes before restarting the cycle, to avoid unnecessary cycles, excessive logging, etc.
There was a problem hiding this comment.
That would also slow down the trades though.
There was a problem hiding this comment.
Does this only affect the agents in staked services? That would be acceptable, and it can always be changed.
If it also affects the non-staked agents, then this would be unnecessary long IMO
There was a problem hiding this comment.
It affects all agents. The rational is that waits for some time before trying to go through the trading cycle. Feel free to modify with a lower value / remove it, if you find it appropriate.
dagacha
left a comment
dagacha
left a comment
There was a problem hiding this comment.
After tests confirmed it works as expected.
LGTM
Update trader to stop after staking KPI met