-
Notifications
You must be signed in to change notification settings - Fork 35
Script security - password protection #55
Conversation
Co-authored-by: Adamantios Zaras <adamantioszaras@gmail.com>
Change password feature
|
Bug valory-xyz/open-autonomy#2088 has been fixed on valory-xyz/open-autonomy#2108 |
Password verification
Adamantios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and the password is not enforced. I do not agree with releasing this as is.
Please clarify what enforcements and where. |
I first used password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this again. The script just validates the password later and not immediately.
The script validates the password after downloading the trader repository. Possible UX improvement:
(currently we have 2, 1, 3) |
Feature to protect keys generated by the script.
IMPORTANT: In order to be merged, this PR requires a version of the trader that supports a version of Open Autonomy including this fix: valory-xyz/open-autonomy#2108