This repository was archived by the owner on May 29, 2025. It is now read-only.
Write an advanced usage section #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
force-pushed
the
docs/advanced-usage
branch
from
c6dd75f to
ee93e40
Compare
Adamantios
force-pushed
the
docs/advanced-usage
branch
from
ee93e40 to
0153504
Compare
| cp ".trader_runner/available_tools_store.json" ".trader_runner/available_tools_store_$(date +"%d-%m-%Y")".json | ||
| ``` | ||
|
|
||
| ##### Tool selection |
Contributor
There was a problem hiding this comment.
Step 1 should be to tell the user about the env variable that adjusts the policy punishment
Collaborator
Author
There was a problem hiding this comment.
We do not have an environment variable for the punishment, this is fixed to the mech's price.
Collaborator
There was a problem hiding this comment.
Opened an issue valory-xyz/trader#120
I suggest we close this comment.
Comment on lines
+164
to
+167
| It can easily be done, by removing this method call, | ||
| [here](https://github.com/valory-xyz/trader-quickstart/blob/0f093ebbf0857b8484a017912c3992f00fbe1a29/run_service.sh#L698), | ||
| in order to set your own custom warm start. | ||
| Setting your own custom weights can be done by editing the corresponding files in `.trader_runner`. |
Contributor
There was a problem hiding this comment.
Why can we not simply say: if you want a different warm start adjust such and such file?
Collaborator
Author
There was a problem hiding this comment.
Because the function call needs to be removed as well, to avoid overwriting the files' contents.
dagacha
approved these changes
Oct 30, 2023
Collaborator
dagacha
left a comment
dagacha
left a comment
There was a problem hiding this comment.
Made a few suggestions. O/w LGTM
Co-authored-by: David Galindo <35235550+dagacha@users.noreply.github.com>
dagacha
reviewed
Oct 31, 2023
| Moreover, you may store your current policy as a backup before editing those files, using the following command: | ||
|
|
||
| ```shell | ||
| cp ".trader_runner/available_tools_store.json" ".trader_runner/available_tools_store_$(date +"%d-%m-%Y")".json |
Collaborator
There was a problem hiding this comment.
Suggested change
| cp ".trader_runner/available_tools_store.json" ".trader_runner/available_tools_store_$(date +"%d-%m-%Y")".json | |
| cp ".trader_runner/available_tools_store.json" ".trader_runner/available_tools_store_$(date +"%d-%m-%Y")".json | |
| cat ".trader_runner/policy_store.json" >> ".trader_runner/available_tools_store_$(date +"%d-%m-%Y")".json |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.