Conversation
i3or1s
left a comment
i3or1s
left a comment
There was a problem hiding this comment.
maybe nicer name for style would be style.css instead of css1.css
about.html
Outdated
| <div class="offset-l3 col l6"> | ||
| <h2 class="h2_about_section_2"> | ||
| Games concept testing<font color="#FF9600">.</font> | ||
| Games concept testing<span class="color">.</span> |
There was a problem hiding this comment.
color does not indicate which color is it actually. Use name that will describe which color is it since it is used in more then one scenario. Maybe something like primary-color, secondary-color or text-primary-color, text-secondary-color
resources/css1.css
Outdated
| } | ||
| .h2_about_section_2{ | ||
| margin-top: 160px; | ||
| font-weight: 800 !important; |
There was a problem hiding this comment.
!important should not be used unless it is really necessary.
Maybe treat font-weights as separate classes along with font-family etc... Look at How To Set Weights And Styles With The font-face Declaration for inspiration.
resources/css1.css
Outdated
| margin-top: 20px; | ||
| } | ||
| .about_h2{ | ||
| float: left; |
There was a problem hiding this comment.
try not to use float since you are already using materializecss
resources/css1.css
Outdated
| } | ||
| .about_h2{ | ||
| float: left; | ||
| font-size: 1.5em; |
There was a problem hiding this comment.
try to stick to the one unit declaration for font-size (i see that there is mix between px and em).
Something to Read
resources/css1.css
Outdated
| } | ||
| body{ | ||
| font-family: "Helvetica Neue", Helvetica, Arial, sans-serif; | ||
| /*font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;*/ |
|
I removed all the necessary things and i changed all as you were sugested. |
2 participants
change lowercase in tab icon