fix(amazon): address review issues — missing icon, schema mismatch, dead code, pluralization#19
Closed
Copilot wants to merge 2 commits intofeat/amazon-connectorfrom
Closed
fix(amazon): address review issues — missing icon, schema mismatch, dead code, pluralization#19Copilot wants to merge 2 commits intofeat/amazon-connectorfrom
Copilot wants to merge 2 commits intofeat/amazon-connectorfrom
Conversation
8 tasks
…ector Co-authored-by: letonchanh <5548342+letonchanh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Playwright connector for Amazon profile and order history
fix(amazon): address review issues — missing icon, schema mismatch, dead code, pluralization
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of the Amazon connector PR surfaced several bugs and code quality issues.
Changes
icons/amazon.svg(new): Created missing icon in Amazon brand orange (#FF9900) — metadata already referenced it but the file didn't exist, which would break the UI.schemas/amazon.orders.json: RemovedorderIdfromrequired. The extractor pushes orders whenorderId || items.length > 0, so orders with items but no parsed ID are valid and would fail schema validation.amazon-playwright.js:progressPrefixparameter fromenrichOrdersWithPricesstate.isComplete— set at end of run but never read"across 1 years"→"across 1 year"with proper pluralizationregistry.json: Updatedsha256checksum foramazon-playwright.js🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.