Release framework v1.4.2#36
Merged
Merged
Conversation
Modal sm/lg/xl classes now set width via --vd-modal-dialog-max-width so documented dialog-level size modifiers render real desktop width steps. Adds regression fixtures and Playwright coverage for the tier spacing. Co-authored-by: Cursor <cursoragent@cursor.com>
Portal date/time picker popups to document.body with anchored positioning, restore distinct modal size tiers, and rebuild dist at 1.4.2. Co-authored-by: Cursor <cursoragent@cursor.com>
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (6 files — unchanged from prior review)
Fix these issues in Kilo Cloud Reviewed by deepseek-v4-pro · 293,132 tokens |
Co-authored-by: kilo-code-bot[bot] <240665456+kilo-code-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vd-modal-smthrough.vd-modal-xl) with dialog-level modifier support and new Playwright coverage.document.bodywith anchored positioning, scroll/resize repositioning, and overflow-safe CSS.Test plan
pnpm build— dist rebuilt at v1.4.2pnpm test— modal size tier and picker portal specsMade with Cursor